fix: prefix staged tarball path so npm does not treat it as git - #482
Merged
Conversation
npm 11+ parses a bare packed/*.tgz argument as GitHub owner/repo shorthand, so npm stage publish ran git ls-remote against ssh://git@github.com/packed/docula-3.0.0.tgz.git and failed. Prefix the glob with ./ so npa treats it as a local file. Co-authored-by: Jared Wray <me@jaredwray.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2760 2760
Branches 846 837 -9
=========================================
Hits 2760 2760 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix for the release workflow.
Why this change is needed?
The v3.0.0 release failed at the Stage publish step (run 32056846194) with:
This is not an OIDC / trusted-publisher problem. The trusted publisher is already configured for
release.yamlwithnpm stage publish. npm 11+ (npm-package-arg) parses a baredir/file.tgzargument as GitHubowner/reposhorthand, sopacked/docula-3.0.0.tgzbecamegithub:packed/docula-3.0.0.tgz.What this PR does
Prefixes the packed tarball glob with
./so npa treats it as a local file:Reproduced locally with the same npm 11.19.0 the workflow installs:
npm stage publish packed/*.tgz --dry-run→ exit 128,git ls-remote ssh://git@github.com/packed/docula-repro-dummy-3.0.0.tgz.gitnpm stage publish ./packed/*.tgz --dry-run→ exit 0,Staging ... (dry-run)pnpm test: 17 files, 866 tests passed, 100% coverage. Workflow-only change; no application source to cover with unit tests.After merge, re-run the
releaseworkflow (or re-release) so 3.0.0 can be staged.